Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upShow video preview on cover media settings panel #18009
Merged
+8
−0
Conversation
jorgefilipecosta
force-pushed the
update/show-video-preview-on-cover-media-settings
branch
from
c3e507e
to
c654eb6
This comment has been minimized.
This comment has been minimized.
|
Hi @mapk, any thoughts on this change? |
|
I just tested this and it works great! I see the video playing in the sidebar under the Media settings.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jorgefilipecosta commentedOct 17, 2019
•
edited
Description
This PR adds a video preview on the media settings panel. Before I just rendered the clear media button for video backgrounds. I think we should show a preview of the media we are cleaning, also I think the UI looks better if we show a preview.
For image backgrounds, we show the focal point picker which is also a preview of the image.
How has this been tested?
I added a cover block.
I selected a video as a background.
I verified a video preview appeared on the media settings panel on the block inspector.
Before
After