Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show video preview on cover media settings panel #18009

Merged

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Oct 17, 2019

Description

This PR adds a video preview on the media settings panel. Before I just rendered the clear media button for video backgrounds. I think we should show a preview of the media we are cleaning, also I think the UI looks better if we show a preview.
For image backgrounds, we show the focal point picker which is also a preview of the image.

How has this been tested?

I added a cover block.
I selected a video as a background.
I verified a video preview appeared on the media settings panel on the block inspector.

Before

Screenshot 2019-11-14 at 16 15 46

After

Screenshot 2019-11-14 at 16 14 21

@jorgefilipecosta jorgefilipecosta force-pushed the update/show-video-preview-on-cover-media-settings branch from c3e507e to c654eb6 Nov 14, 2019
@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

jorgefilipecosta commented Nov 14, 2019

Hi @mapk, any thoughts on this change?

@mapk
mapk approved these changes Nov 23, 2019
Copy link
Contributor

mapk left a comment

I just tested this and it works great! I see the video playing in the sidebar under the Media settings.

Screen Shot 2019-11-22 at 4 20 14 PM

@jorgefilipecosta jorgefilipecosta merged commit fa0e472 into master Nov 23, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the update/show-video-preview-on-cover-media-settings branch Nov 23, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.