Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cover block may contain has-background-dim-NaN class #18011

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Oct 17, 2019

Description

The cover block contained a bug and in some cases added a has-background-dim-NaN class.

How has this been tested?

I added a cover block.
I selected an image for the block.
I added an overlay color.
I set the opacity value to 80%.
I pressed the "Clear Media" button, I went to the code editor and verified the button block does not contain the has-background-dim-NaN class (on master there is a bug and the class is added).

@jorgefilipecosta jorgefilipecosta merged commit d220ba2 into master Nov 26, 2019
7 checks passed
7 checks passed
pull-request-automation
Details
Header rules - gutenberg-playground No header rules processed
Details
Pages changed - gutenberg-playground 3 new files uploaded
Details
Redirect rules - gutenberg-playground No redirect rules processed
Details
Mixed content - gutenberg-playground No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
Details
@jorgefilipecosta jorgefilipecosta deleted the fix/cover-block-may-contain-has-background-dim-NaN-class branch Nov 26, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.