Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cover to video and image transforms #18023

Merged
merged 1 commit into from Dec 5, 2019

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Oct 18, 2019

Description

The transform of cover to video and image was implemented before solid color backgrounds were implemented.
Currently if one selects a solid color as a background, without any image or video it is still possible to transform the cover block into an image or a video.
This PR removes the possibility of transforming cover blocks with a solid color background into a video or image. I think these transforms don't make sense.

How has this been tested?

I added a cover block.
I selected a solid color background.
I verified it was not possible to transform the block into an image or video.

@jorgefilipecosta jorgefilipecosta force-pushed the fix/cover-to-video-and-image-transforms branch 3 times, most recently from d071667 to 334fae7 Nov 14, 2019
@jorgefilipecosta jorgefilipecosta force-pushed the fix/cover-to-video-and-image-transforms branch 2 times, most recently from 794f265 to c062b4d Dec 5, 2019
@jorgefilipecosta jorgefilipecosta force-pushed the fix/cover-to-video-and-image-transforms branch from c062b4d to 1a2deaa Dec 5, 2019
@jorgefilipecosta jorgefilipecosta merged commit d721aca into master Dec 5, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the fix/cover-to-video-and-image-transforms branch Dec 5, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
scruffian added a commit to scruffian/gutenberg that referenced this pull request Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.