Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update columns index.js adding translatable (i18n) parts #18162

Merged
merged 2 commits into from Dec 17, 2019
Merged

Update columns index.js adding translatable (i18n) parts #18162

merged 2 commits into from Dec 17, 2019

Conversation

nukaga
Copy link
Contributor

@nukaga nukaga commented Oct 29, 2019

Adding translatable (i18n) parts

Description

Part of the series of sentences displayed in "lorem ipsum" was not translatable.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Adding translatable (i18n) parts
Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nukaga thank you for your contribution 👍
These strings are example text and not supposed to be readable, but I guess in some languages with different charsets this example text may not look good, so making them translatable seems like a solution. Any thoughts on this @swissspidy?

@swissspidy
Copy link
Member

I guess in some languages with different charsets this example text may not look good

Just think about Arabic or Japanese and how lorem ipsum does not work for these languages.

@swissspidy swissspidy added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Oct 31, 2019
@swissspidy
Copy link
Member

Ideally we'd also add some translator comment that mentions that this is example text.

@torounit
Copy link
Member

torounit commented Nov 6, 2019

Should use _x instead of __ ?

Copy link
Member

@jorgefilipecosta jorgefilipecosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jorgefilipecosta jorgefilipecosta merged commit 8b4922e into WordPress:master Dec 17, 2019
@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Dec 17, 2019

Should use _x instead of __ ?

Hi @torounit, _x should be used when the same word/string can have different translations depending on the context it is used. It seems this example strings don't fit that use case, so I think we can use __.

@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants