Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block navigator to sidebar panel for nav block #18202

Merged
merged 2 commits into from Oct 31, 2019

Conversation

@talldan
Copy link
Contributor

talldan commented Oct 31, 2019

Description

Closes #18190

Adds the navigator to the block sidebar panel

How has this been tested?

  1. Add a Navigation Block
  2. Add some menu items
  3. Check the sidebar of the Navigation Block
  4. Expect to see the Block Navigator

Screenshots

Screen Shot 2019-10-31 at 3 21 21 pm

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
@talldan

This comment has been minimized.

Copy link
Contributor Author

talldan commented Oct 31, 2019

I like this. It might also be good to display it on the menu items in the same place (and still scoped to the Navigation Menu) so that it's possible to navigate back and forth.

@draganescu

This comment has been minimized.

Copy link
Contributor

draganescu commented Oct 31, 2019

I feel like the navigation structure should remain in the sidebar for the submenu items too, maybe I expect that it is there while I am in the menu and it always shows the current item.

@talldan talldan added this to 👀 PRs to review in Navigation block via automation Oct 31, 2019
@talldan

This comment has been minimized.

Copy link
Contributor Author

talldan commented Oct 31, 2019

@draganescu I've experimented with that over on #18203.

The implementation is very hacky as I ran out of time and just did whatever was quickest to show the concept.

Copy link
Contributor

draganescu left a comment

This works great.

@draganescu draganescu merged commit 60d666e into master Oct 31, 2019
7 checks passed
7 checks passed
pull-request-automation
Details
Header rules - gutenberg-playground No header rules processed
Details
Pages changed - gutenberg-playground 3 new files uploaded
Details
Redirect rules - gutenberg-playground No redirect rules processed
Details
Mixed content - gutenberg-playground No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Oct 31, 2019
@draganescu draganescu deleted the add/navigator-to-nav-sidebar branch Oct 31, 2019
daniloercoli added a commit that referenced this pull request Nov 5, 2019
…rnmobile/gb-mobile-872-JSApplicationIllegalArgumentException-in-RCTAztecView

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Update: Default gradients. (#18214)
  Fix: setting a preset color on pullquote default style makes the block invalid (#18194)
  Fix default featured image size (#15844)
  Fix postmeta radio regression. (#18183)
  Components: Switch screen-reader-text to VisuallyHidden (#18165)
  [rnmobile] Release 1.16.0 to master (#18261)
  Template Loader: Add theme block template resolution. (#18247)
  Add a README file for storybook directory (#18245)
  Add editor-gradient-presets to get_theme_support (#17841)
  Add "Image Title Attribute" as an editable attribute on the image block (#11070)
  enables horizontal movers in social blocks (#18234)
  [RNMobile] Add mobile Spacer component (#17896)
  Add experimental `ResponsiveBlockControl` component (#16790)
  Fix mover for floats. (#18230)
  Rename Component to WPComponent in docstring (#18226)
  Colors Selector: replace `Aa` text by SVG icon (#18222)
  Removed gif from README (#18200)
  makes the submenu items stacked vertically (#18221)
  Add block navigator to sidebar panel for nav block (#18202)
  Fix: consecutive updates may trigger a blocks reset (#18219)
  ...
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
* Add block navigator to sidebar panel for nav block

* Change name of panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.