Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Default gradients #18214

Merged
merged 1 commit into from Nov 5, 2019
Merged

Update: Default gradients #18214

merged 1 commit into from Nov 5, 2019

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Oct 31, 2019

Description

@jasmussen updated the default gradients in #17603. This change is not directly related to the custom gradients and makes rebasing hard.
I'm extracting this change to a separate PR, so both PR's are easier to review.

How has this been tested?

I verified the new gradients work as expected on the button and cover block.

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Oct 31, 2019

I've got a bit on my plate today so unsure the details of the change. But just for the sake of making rebases simpler, this seems fine 👍 👍

What matters is we have two rows of gradient presets, the ones shown in #17603 (comment) and no more. Fine if the names change, fine if classnames change, fine if it takes a bit of PR juggling to make it eventually happen 😉

@jorgefilipecosta jorgefilipecosta force-pushed the update/default-gradients branch from ef3d775 to fb643b5 Nov 4, 2019
@jorgefilipecosta jorgefilipecosta force-pushed the update/default-gradients branch from fb643b5 to c80220c Nov 4, 2019
@jorgefilipecosta jorgefilipecosta merged commit e8e115d into master Nov 5, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the update/default-gradients branch Nov 5, 2019
daniloercoli added a commit that referenced this pull request Nov 5, 2019
…rnmobile/gb-mobile-872-JSApplicationIllegalArgumentException-in-RCTAztecView

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Update: Default gradients. (#18214)
  Fix: setting a preset color on pullquote default style makes the block invalid (#18194)
  Fix default featured image size (#15844)
  Fix postmeta radio regression. (#18183)
  Components: Switch screen-reader-text to VisuallyHidden (#18165)
  [rnmobile] Release 1.16.0 to master (#18261)
  Template Loader: Add theme block template resolution. (#18247)
  Add a README file for storybook directory (#18245)
  Add editor-gradient-presets to get_theme_support (#17841)
  Add "Image Title Attribute" as an editable attribute on the image block (#11070)
  enables horizontal movers in social blocks (#18234)
  [RNMobile] Add mobile Spacer component (#17896)
  Add experimental `ResponsiveBlockControl` component (#16790)
  Fix mover for floats. (#18230)
  Rename Component to WPComponent in docstring (#18226)
  Colors Selector: replace `Aa` text by SVG icon (#18222)
  Removed gif from README (#18200)
  makes the submenu items stacked vertically (#18221)
  Add block navigator to sidebar panel for nav block (#18202)
  Fix: consecutive updates may trigger a blocks reset (#18219)
  ...
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.