Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors Selector: replace `Aa` text by SVG icon #18222

Merged
merged 4 commits into from Nov 1, 2019
Merged

Conversation

@retrofox
Copy link
Contributor

retrofox commented Oct 31, 2019

Description

It changes the text used to implement the Aa icon of the ColorsSelector component by an SVG icon.

How has this been tested?

  1. Apply this patch
  2. Check the toolbar button of the ColorsSelector

Screenshots

image

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
@retrofox retrofox added this to 👀 PRs to review in Navigation block via automation Oct 31, 2019
@retrofox retrofox force-pushed the update/colors-selector-icon branch from 681b9dd to 0830bd2 Oct 31, 2019
@retrofox retrofox force-pushed the update/colors-selector-icon branch from 0830bd2 to b9e85a9 Oct 31, 2019
Copy link
Contributor

draganescu left a comment

tested works great

@shaunandrews

This comment has been minimized.

Copy link

shaunandrews commented Oct 31, 2019

Looks pretty good. I think the icon is a little too big. I opened up the web inspector and added a padding: 2px to .block-library-colors-selector .block-library-colors-selector__state-selection and it looks better to my eyes:

image

@retrofox

This comment has been minimized.

Copy link
Contributor Author

retrofox commented Oct 31, 2019

I opened up the web inspector and added a padding: 2px to .block-library-colors-selector .block-library-colors-selector__state-selection and it looks better to my eyes:

Handled here 915c754

@obenland obenland merged commit 83e7216 into master Nov 1, 2019
7 checks passed
7 checks passed
pull-request-automation
Details
Header rules - gutenberg-playground No header rules processed
Details
Pages changed - gutenberg-playground 5 new files uploaded
Details
Redirect rules - gutenberg-playground No redirect rules processed
Details
Mixed content - gutenberg-playground No mixed content detected
Details
Travis CI - Pull Request Build Passed
Details
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Nov 1, 2019
@obenland obenland deleted the update/colors-selector-icon branch Nov 1, 2019
@retrofox

This comment has been minimized.

Copy link
Contributor Author

retrofox commented Nov 1, 2019

Thanks folks for the review, thanks @obenland to merge it.

daniloercoli added a commit that referenced this pull request Nov 5, 2019
…rnmobile/gb-mobile-872-JSApplicationIllegalArgumentException-in-RCTAztecView

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Update: Default gradients. (#18214)
  Fix: setting a preset color on pullquote default style makes the block invalid (#18194)
  Fix default featured image size (#15844)
  Fix postmeta radio regression. (#18183)
  Components: Switch screen-reader-text to VisuallyHidden (#18165)
  [rnmobile] Release 1.16.0 to master (#18261)
  Template Loader: Add theme block template resolution. (#18247)
  Add a README file for storybook directory (#18245)
  Add editor-gradient-presets to get_theme_support (#17841)
  Add "Image Title Attribute" as an editable attribute on the image block (#11070)
  enables horizontal movers in social blocks (#18234)
  [RNMobile] Add mobile Spacer component (#17896)
  Add experimental `ResponsiveBlockControl` component (#16790)
  Fix mover for floats. (#18230)
  Rename Component to WPComponent in docstring (#18226)
  Colors Selector: replace `Aa` text by SVG icon (#18222)
  Removed gif from README (#18200)
  makes the submenu items stacked vertically (#18221)
  Add block navigator to sidebar panel for nav block (#18202)
  Fix: consecutive updates may trigger a blocks reset (#18219)
  ...
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
* colors-selector: replace `Aa` text by SVG icon

* fix eslint erros

* colors-selector: change SVG icon

* colors-selector: reduce icon size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.