Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: Fix warning for Component invalid in VisuallyHidden docstring #18226

merged 1 commit into from Nov 1, 2019


Copy link

mkaz commented Oct 31, 2019


The docstring in the utils.js function fo the VisuallyHidden component used Component as the parameter and return value, and this giving a lint warning.

This PR rename the docstring from Component to WPComponent.

How has this been tested?

npm run lint confirm Warning is no more.

Types of changes

No code change, just function docstring.

gziolo approved these changes Nov 1, 2019
Copy link

gziolo left a comment

Thanks for fixing 👍

@gziolo gziolo merged commit 281d924 into master Nov 1, 2019
7 checks passed
7 checks passed
Header rules - gutenberg-playground No header rules processed
Pages changed - gutenberg-playground 10 new files uploaded
Redirect rules - gutenberg-playground No redirect rules processed
Mixed content - gutenberg-playground No mixed content detected
Travis CI - Pull Request Build Passed
netlify/gutenberg-playground/deploy-preview Deploy preview ready!
@gziolo gziolo deleted the fix/component-docstring branch Nov 1, 2019
daniloercoli added a commit that referenced this pull request Nov 5, 2019

* 'master' of (56 commits)
  Update: Default gradients. (#18214)
  Fix: setting a preset color on pullquote default style makes the block invalid (#18194)
  Fix default featured image size (#15844)
  Fix postmeta radio regression. (#18183)
  Components: Switch screen-reader-text to VisuallyHidden (#18165)
  [rnmobile] Release 1.16.0 to master (#18261)
  Template Loader: Add theme block template resolution. (#18247)
  Add a README file for storybook directory (#18245)
  Add editor-gradient-presets to get_theme_support (#17841)
  Add "Image Title Attribute" as an editable attribute on the image block (#11070)
  enables horizontal movers in social blocks (#18234)
  [RNMobile] Add mobile Spacer component (#17896)
  Add experimental `ResponsiveBlockControl` component (#16790)
  Fix mover for floats. (#18230)
  Rename Component to WPComponent in docstring (#18226)
  Colors Selector: replace `Aa` text by SVG icon (#18222)
  Removed gif from README (#18200)
  makes the submenu items stacked vertically (#18221)
  Add block navigator to sidebar panel for nav block (#18202)
  Fix: consecutive updates may trigger a blocks reset (#18219)
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.