Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a README file for storybook directory #18245

Merged
merged 2 commits into from Nov 2, 2019
Merged

Add a README file for storybook directory #18245

merged 2 commits into from Nov 2, 2019

Conversation

@mkaz
Copy link
Member

mkaz commented Nov 2, 2019

Description

Adds a README file explaining Storybook and providing a link to the live site and instructions on how to run locally.

How has this been tested?

No code, just readme documentation file.

You can view live on the branch here

Types of changes

Meta documentation

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Nov 2, 2019

I’m proposing to integrate the playground into Storybook in #18191. This would move the storybook folder to the top level directory. In addition, I updated the contributors guide to replace the section about the playground with the one about Storybook.

We can merge this one first but I wanted to share the path I’d like to follow 😃

@Soean
Soean approved these changes Nov 2, 2019
@mkaz mkaz merged commit e4003c4 into master Nov 2, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@mkaz mkaz deleted the add/storybook-readme branch Nov 2, 2019
@gziolo gziolo mentioned this pull request Nov 4, 2019
10 of 10 tasks complete
daniloercoli added a commit that referenced this pull request Nov 5, 2019
…rnmobile/gb-mobile-872-JSApplicationIllegalArgumentException-in-RCTAztecView

* 'master' of https://github.com/WordPress/gutenberg: (56 commits)
  Update: Default gradients. (#18214)
  Fix: setting a preset color on pullquote default style makes the block invalid (#18194)
  Fix default featured image size (#15844)
  Fix postmeta radio regression. (#18183)
  Components: Switch screen-reader-text to VisuallyHidden (#18165)
  [rnmobile] Release 1.16.0 to master (#18261)
  Template Loader: Add theme block template resolution. (#18247)
  Add a README file for storybook directory (#18245)
  Add editor-gradient-presets to get_theme_support (#17841)
  Add "Image Title Attribute" as an editable attribute on the image block (#11070)
  enables horizontal movers in social blocks (#18234)
  [RNMobile] Add mobile Spacer component (#17896)
  Add experimental `ResponsiveBlockControl` component (#16790)
  Fix mover for floats. (#18230)
  Rename Component to WPComponent in docstring (#18226)
  Colors Selector: replace `Aa` text by SVG icon (#18222)
  Removed gif from README (#18200)
  makes the submenu items stacked vertically (#18221)
  Add block navigator to sidebar panel for nav block (#18202)
  Fix: consecutive updates may trigger a blocks reset (#18219)
  ...
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
* Add a README file for storybook directory

* Fix typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.