Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Extract Gallery component for semi-cross-platform Gallery block #18265
This PR extracts a
This PR is part of the PR hierarchy described here. This PR can be used to test the aggregate changeset and integration of components within the related PRs.
The icon prop will be hidden for web after the cross-platform PR for
I've extracted the block icon into a shared-icon file (with web and mobile variants) so that we can apply dark-mode styles on mobile. Also, although the icons use the same underlying svg, they are wrapped differently. Web styles / behaviors should be preserved in this PR.
To make separator indentation consistent for controls in the bottomsheet on mobile, it is currently necessary to add
This PR should not result in any change in behavior for the web version of Gallery block.
Checkout this PR and test locally (
Also, all associated automated tests should pass.
Related PRs can be tested via this PR.
jorgefilipecosta left a comment
Things worked well in my tests, and I did not found any regression!