Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Broken link in MediaUpload Documentation #18277

Conversation

@henryholtgeerts
Copy link
Contributor

henryholtgeerts commented Nov 4, 2019

Description

Corrected a broken link, now links to appropriate code from 'edit-post' package.

Fixes #18056

How has this been tested?

Tested the new readme file in my browser, link behaves as expected.

Screenshots

n/a

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
Corrected a broken link, now links to appropriate code from 'edit-post' package
@henryholtgeerts henryholtgeerts changed the title Update MediaUpload Documentation Fix: Broken link in MediaUpload Documentation Nov 5, 2019
@henryholtgeerts henryholtgeerts changed the title Fix: Broken link in MediaUpload Documentation Fix: Broken link in MediaUpload Documentation [Bug] Nov 5, 2019
@henryholtgeerts henryholtgeerts changed the title Fix: Broken link in MediaUpload Documentation [Bug] Fix: Broken link in MediaUpload Documentation Nov 5, 2019
@henryholtgeerts henryholtgeerts changed the title Fix: Broken link in MediaUpload Documentation Fix: Broken link in MediaUpload Documentation [Type] Bug Nov 5, 2019
Copy link
Member

jorgefilipecosta left a comment

Hi @henryholtgeerts thank you for your contribution 👍 The component is now implemented at https://github.com/WordPress/gutenberg/blob/master/packages/media-utils/src/components/media-upload/index.js. Would it be possible to update this PR ? Thank you in advance!

-updated link for new component location
@henryholtgeerts

This comment has been minimized.

Copy link
Contributor Author

henryholtgeerts commented Nov 12, 2019

No problem @jorgefilipecosta ! Just updated

Copy link
Member

jorgefilipecosta left a comment

Thank you for the updates @henryholtgeerts. LGTM 👍

@jorgefilipecosta jorgefilipecosta changed the title Fix: Broken link in MediaUpload Documentation [Type] Bug Fix: Broken link in MediaUpload Documentation Nov 18, 2019
@jorgefilipecosta jorgefilipecosta merged commit 9441c16 into WordPress:master Nov 18, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.