Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigation-menu-item: rename link ID to `id` #18346

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@retrofox
Copy link
Contributor

retrofox commented Nov 6, 2019

Description

This PR simply rename the linkId attribute of the <NavigationMenuItem /> by id.

How has this been tested?

Once the changes are applied check that the Navigation menu works as expected. Additionally, you can check that the attribute name has been updated using the dev tool.

Screen Shot 2019-11-06 at 4 19 15 PM

@retrofox retrofox added this to 👀 PRs to review in Navigation block via automation Nov 6, 2019
@draganescu draganescu merged commit 4a49e3a into master Nov 7, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Nov 7, 2019
@draganescu draganescu deleted the update/navigation-menu-item-link-id branch Nov 7, 2019
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.