Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden nested images in content column #18347

Merged
merged 5 commits into from Nov 12, 2019
Merged

Conversation

@CreativeDive
Copy link
Contributor

CreativeDive commented Nov 6, 2019

Media/Text block bug with nested Image block: Image is not visible

closes #18296

CreativeDive added 4 commits Oct 7, 2019
Left aligned blocks should not inherited "float:left" to nested blocks.

In reference to #17793
Media/Text block bug with nested Image block: Image is not visible #18296
Media/Text block bug with nested Image block: Image is not visible #18296
Fix hidden nested images in content column
Co-Authored-By: Riad Benguella <benguella@gmail.com>
Copy link
Contributor

youknowriad left a comment

👍 Thanks

@CreativeDive

This comment has been minimized.

Copy link
Contributor Author

CreativeDive commented Nov 12, 2019

👍 Thanks

Thank you for helping. A question for the future. How I can sync my fork with the current gutenberg master, before I edit code for the PR?

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Nov 12, 2019

@CreativeDive This page might help https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork

If you're still having trouble, let me know.

@youknowriad youknowriad merged commit e9fcbdc into WordPress:master Nov 12, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.