Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserves style of menu items when in edit mode #18367

Merged
merged 4 commits into from Nov 8, 2019

Conversation

@draganescu
Copy link
Contributor

draganescu commented Nov 7, 2019

Description

Closes #18331

How has this been tested?

Tested locally

Screenshots

Screenshot 2019-11-07 at 13 46 56

Types of changes

Removed some CSS from the editor css of the navigation menu item component. Made the font styling inherit.

@draganescu draganescu changed the title fixes look of editing menu items Preserves style of menu items when in edit mode Nov 8, 2019
@draganescu draganescu force-pushed the fix/menu-item-edit-styles branch from c837e45 to 4bdf63d Nov 8, 2019
@mtias

This comment has been minimized.

Copy link
Contributor

mtias commented Nov 8, 2019

For completeness, this was fixed before and regressed in #18172 cc @retrofox

@mtias

This comment has been minimized.

Copy link
Contributor

mtias commented Nov 8, 2019

All red, I like it :)

Copy link
Contributor

retrofox left a comment

LGTM.

@draganescu draganescu merged commit eba7de4 into master Nov 8, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@draganescu draganescu deleted the fix/menu-item-edit-styles branch Nov 8, 2019
@youknowriad youknowriad added this to the Gutenberg 6.9 milestone Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
* fixes look of editing menu items

* removed fixed font size for the menu item

* removes css props for menu items which had the value inherit as it is the default

* removed min width for selected menu item as it appeared to be a rebase mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.