Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Broken link in "Updating to New Release" section #18403

Merged
merged 1 commit into from Nov 12, 2019

Conversation

@gregrickaby
Copy link
Contributor

gregrickaby commented Nov 8, 2019

Description

The links to the changelog were 404-ing. I pointed them to the correct URL on Github.

@gregrickaby gregrickaby changed the title Fix: Broken link in "Updating to New Release section" Fix: Broken link in "Updating to New Release" section Nov 8, 2019
@Soean
Soean approved these changes Nov 8, 2019
@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Nov 8, 2019

Can you provide more details in which context it shows 404? I tried on GitHub and npm and they properly link opening the changelog file.

@Soean

This comment has been minimized.

@gregrickaby

This comment has been minimized.

Copy link
Contributor Author

gregrickaby commented Nov 8, 2019

@gziolo Just agreeing with @Soean, the links are in the Handbook: https://developer.wordpress.org/block-editor/packages/packages-scripts/#updating-to-new-release

Sorry I should have mentioned that in my original PR note.

@gziolo
gziolo approved these changes Nov 12, 2019
Copy link
Member

gziolo left a comment

Cool, it makes sense then 👍

@gziolo gziolo merged commit b5e5c80 into WordPress:master Nov 12, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.