Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Snackbar - Add Actions prop story #18404

Merged
merged 3 commits into from Nov 11, 2019
Merged

Conversation

@Soean
Copy link
Member

Soean commented Nov 8, 2019

Description

Add the With Actions story to the Snackbar.

How has this been tested?

run npm run design-system:dev
Browse to the local Storybook instance
See Snackbar With Actions story is rendered when selected in the left-hand navigation

Types of changes

New feature (non-breaking change which adds functionality)

@gziolo
gziolo approved these changes Nov 11, 2019
Copy link
Member

gziolo left a comment

I can’t test on mobile because Netlify integration didn’t trigger. Code looks good 👍


export const withActions = () => {
const content = text( 'Content', 'Use Snackbars with an action link to an external page.' );
const actions = [ { url: text( 'URL', 'https://wordpress.org' ), label: text( 'label', 'Open WP.org' ) } ];

This comment has been minimized.

Copy link
@gziolo

gziolo Nov 11, 2019

Member

We could experiment with the object knob as well: https://www.npmjs.com/package/@storybook/addon-knobs

@Soean Soean changed the title Storybook: Snackbar - Add Actions prop stroy Storybook: Snackbar - Add Actions prop story Nov 11, 2019
@Soean Soean merged commit 1b15c30 into master Nov 11, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@Soean Soean deleted the storybook/update-snackbar branch Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
* Add Actions prop

* add editable params

* Fix typo
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.