Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix excess theme styling on Social Links block links #18410

Merged
merged 2 commits into from Nov 11, 2019

Conversation

@richtabor
Copy link
Contributor

richtabor commented Nov 8, 2019

Description

Fixes #18115 by adding styles to remove excess underlines, false underlines (via 1px solid shadows), and borders to the <a> elements within the Social Links block.

How has this been tested?

Tested in supported browsers and with core themes that have been reported with this issue.

Screenshots

Twenty Fifteen theme before/after:
2015-before
2015-after

Twenty Seventeen theme before/after:
2017-before
2017-after

Types of changes

Style-only changes within the block's style.scss stylesheet.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
@richtabor richtabor requested a review from mkaz as a code owner Nov 8, 2019
@richtabor richtabor self-assigned this Nov 8, 2019
@mkaz
mkaz approved these changes Nov 10, 2019
Copy link
Member

mkaz left a comment

Thanks, looks like a good fix. 👍

@karmatosed karmatosed merged commit fabfd5f into master Nov 11, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@karmatosed karmatosed deleted the fix/18115/remove-underline-social-links branch Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
* Ensure border, decoration or shadow does not effect social links

* Remove !important properties
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.