Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/nav menu item add link style #18435

Merged
merged 5 commits into from Nov 11, 2019
Merged

Conversation

@retrofox
Copy link
Contributor

retrofox commented Nov 11, 2019

Description

This PR adds styles to the menu items when they have defined a link. The link color is the same that the text color.

Fixes #18305

How has this been tested?

Edit menu item adding/removing a/the link. It should show/hide the line border-bottom on it.

Screenshots

nav-menu-no-link

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
@retrofox retrofox requested a review from mapk Nov 11, 2019
Copy link
Contributor

getdave left a comment

This looks good to me. I think the Block needs some distinction between linked and un-linked items so this is a good start. If the design needs tweaking that can be handled in another PR.

@retrofox retrofox merged commit 823fb75 into master Nov 11, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Nov 11, 2019
@retrofox retrofox deleted the update/nav-menu-item-add-link-style branch Nov 11, 2019
CreativeDive added a commit to CreativeDive/gutenberg that referenced this pull request Nov 12, 2019
* navigation-menu-item: add has-link CSS class.

* navigation-menu-item: set base styes for links

* navigation-menu: set inline styles usedfor links

* navigation-menu-item: move link style to richtext

* navigation-menu-item: remove unneeded css rule
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.