Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update getting-started.md #18436

Merged
merged 1 commit into from Nov 23, 2019
Merged

Update getting-started.md #18436

merged 1 commit into from Nov 23, 2019

Conversation

@davidshq
Copy link
Contributor

davidshq commented Nov 11, 2019

Description

Added note that python is a prerequisite to installation using npm install

npm install requires Python to install successfully. While this is included automatically with most Linux variations it is not included with Windows and Apple is removing it from MacOS.

How has this been tested?

On local Windows 10 Pro system.

Screenshots

Types of changes

Change in documentation.

npm install requires Python to install successfully. While this is included automatically with most Linux variations it is not included with Windows and Apple is removing it from MacOS.
@youknowriad youknowriad requested review from ntwb and mkaz Nov 12, 2019
@mkaz
mkaz approved these changes Nov 23, 2019
Copy link
Member

mkaz left a comment

Good catch, we shouldn't assume it is installed. 👍

This is due to node-gyp which is needed for building sass. Their dependencies are our dependencies.

@mkaz mkaz merged commit e2f0151 into WordPress:master Nov 23, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.