Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix CSS styles of ColorPicker #18448
This PR attempts to polish the styling of the ColorPicker component when used outside of WordPress.
Types of changes
CSS and visual.
youknowriad left a comment
I think it's fine to override button styles to achieve this.
jasmussen left a comment
This seems good to me from a design POV.
The icon looks like a dropdown, but isn't a dropdown. It's not critical we fix this because the alternatives aren't that great, but here are some thoughts for alternative icons:
@richtabor Ooo. That's a great suggestion. Wow, I too thought it was a dropdown
ItsJonQ left a comment
I've attempted to restart the Travis tests. They were failing at the E2E parts. I don't think it was anything this PR did. Hopefully, it'll resolve itself this time around
I agree with @jasmussen .