Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Typos, Remove Extra Commas, Add Missing Commas #18450
Thanks for taking the time to review my changes.
I am confused by your change request. It sounds like you want me to use Oxford commas. I prefer Oxford commas too. This PR doesn't remove any Oxford commas. In fact, it adds some. The commas that were removed weren't Oxford commas. Please see https://en.wikipedia.org/wiki/Serial_comma.
The documentation on the Oxford comma is incomplete. The Oxford comma only applies when the list is 3 or more items. That is, a list of two items should not have a comma before the last conjunction.
mkaz left a comment
@dhurlburtusa my apologies, reading through the diff changes I noticed the removal of a few commas before the additional comma you added after strike-through and I misread the diff as you were removing it, but in fact you were adding it.
Thanks for your patience and clarifying