Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typos, Remove Extra Commas, Add Missing Commas #18450

Merged
merged 2 commits into from Nov 24, 2019

Conversation

@dhurlburtusa
Copy link
Contributor

dhurlburtusa commented Nov 12, 2019

Description

Fix Typos, Remove Extra Commas, Add Missing Commas

Copy link
Member

mkaz left a comment

Thanks for the contribution.

The Oxford Comma is the preferred style, see Documentation Grammar Guide

The other changes look good. 👍

@dhurlburtusa

This comment has been minimized.

Copy link
Contributor Author

dhurlburtusa commented Nov 23, 2019

Hello @mkaz,

Thanks for taking the time to review my changes.

I am confused by your change request. It sounds like you want me to use Oxford commas. I prefer Oxford commas too. This PR doesn't remove any Oxford commas. In fact, it adds some. The commas that were removed weren't Oxford commas. Please see https://en.wikipedia.org/wiki/Serial_comma.

The documentation on the Oxford comma is incomplete. The Oxford comma only applies when the list is 3 or more items. That is, a list of two items should not have a comma before the last conjunction.

@mkaz
mkaz approved these changes Nov 24, 2019
Copy link
Member

mkaz left a comment

@dhurlburtusa my apologies, reading through the diff changes I noticed the removal of a few commas before the additional comma you added after strike-through and I misread the diff as you were removing it, but in fact you were adding it.

Thanks for your patience and clarifying

@mkaz mkaz merged commit 22368f3 into WordPress:master Nov 24, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.