Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Block on mobile unit tests fail and instructions on how to debug #18454
This PR makes the native mobile tests Travis job necessary to succeed for the whole Travis run to "green".
How has this been tested?
Online via Travis itself on this PR and locally by running
Types of changes
Because there's also a Platform npm package installed too, running the native mobile unit tests locally (at least on macOS) results in picking up the wrong object. Putting the react-native/Libraries/Utilities first, Jest manages to resolve the proper Platform import. See https://github.com/facebook/react-native/blob/v0.60.0/Libraries/react-native/react-native-implementation.js#L324-L326 for the import. The ambiguity seems fixed in RN v0.61.4 with facebook/react-native@62c605e
There is also the Testing Overview document:
We should either move the details about testing there and cross-reference or the other way around. This is really important so it's easy to find details about the native app.
Makes sense and I was thinking something along those line too