Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Navigation block: prevent error in Firefox when removing the navigation block #18455
As described in issue #18356 currently we see an error in Firefox when removing the navigation block. This is caused by a null value which this PR aims to filter out ahead of time.
How has this been tested?
Click "Remove block" on the navigation block:
Types of changes
Bug fix (non-breaking change which fixes an issue)
marekhrabe left a comment
I can no longer see the "unexpected error" overlay over the editor. The console still shows an error (a different one):
Considering the original issue is of a well-described scope and this solution fixes it, I'm happy approving this PR. If I can reproduce the other error consistently, I'll file it separately.