Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix full-wide on mobile regression. #18469

Merged
merged 1 commit into from Nov 18, 2019
Merged

Fix full-wide on mobile regression. #18469

merged 1 commit into from Nov 18, 2019

Conversation

@jasmussen
Copy link
Contributor

jasmussen commented Nov 13, 2019

This is a followup to a regression found in #17875, specifically #17877 (comment).

The PR refactored horizontal margins, including for full-wide blocks. As a result, full-wide blocks would, on the mboile breakpoint, receive too much negative margin.

This PR addresses that.

To test, insert any full wide block, though it's easier to see with the table block as it gets more visibly cropped. Test in TwentyTwenty and with vanilla styles. Test both on mobile (<600px) breaktpoint, and above. There should be no cropping, and no horizontal scrollbars.

However please note that there is an issue with TwentyNineteen editor styles as a result of the PR, and those need to be fixed separately as they need new styles. That is trac'ed here: https://core.trac.wordpress.org/ticket/48526

Screenshots:

Screenshot 2019-11-13 at 09 14 49

Screenshot 2019-11-13 at 09 14 57

@jasmussen jasmussen requested a review from gziolo Nov 13, 2019
@jasmussen jasmussen self-assigned this Nov 13, 2019
@jasmussen jasmussen mentioned this pull request Nov 13, 2019
5 of 5 tasks complete
Copy link
Contributor

youknowriad left a comment

LGTM

@jasmussen

This comment has been minimized.

Copy link
Contributor Author

jasmussen commented Nov 15, 2019

Tests don't seem to be completing.

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Nov 15, 2019

Weird, can you try to rebase and push again?

@jasmussen jasmussen force-pushed the fix/full-wide-regression branch from 3f862f6 to 3606f0a Nov 15, 2019
@jasmussen

This comment has been minimized.

Copy link
Contributor Author

jasmussen commented Nov 15, 2019

Done, thank you.

This is a followup to a regression found in #17875, specifically #17877 (comment).

The PR refactored horizontal margins, including for full-wide blocks. As a result, full-wide blocks would, on the mboile breakpoint, receive too much negative margin.

This PR addresses that.
@jasmussen jasmussen force-pushed the fix/full-wide-regression branch from 3606f0a to 597c129 Nov 18, 2019
@jasmussen jasmussen merged commit 17a6ab0 into master Nov 18, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jasmussen jasmussen deleted the fix/full-wide-regression branch Nov 18, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.