Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Control: fix setting rich-text placeholder #18488

Merged
merged 2 commits into from Nov 13, 2019

Conversation

@retrofox
Copy link
Contributor

retrofox commented Nov 13, 2019

Description

We need to make stronger the CSS rule which overrides the styles for the <URLInput > block properly. It's doable prefixing the rule with the .components-popover CSS class.

After this change 8e13521 is mandatory to remove the > from the CSS rule to make it work, since it is not a straightforward child of the CSS class anymore.

How has this been tested?

Testing with a navigation menu, confirm that the link popover is broken when the item doesn't have defined a link:

Applying this change, the popover should look good again:

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
@retrofox retrofox requested a review from obenland Nov 13, 2019
@retrofox retrofox added this to 👀 PRs to review in Navigation block via automation Nov 13, 2019
@retrofox retrofox requested review from getdave and removed request for youknowriad Nov 13, 2019
retrofox added 2 commits Nov 13, 2019
After this change 8e13521 is mandatory to remove the `>` from the CSS rule to make it work, since it is not a straightforward child of the CSS class anymore.
@retrofox retrofox force-pushed the update/link-popover-fix-visual-bug branch from 80a9039 to ecad058 Nov 13, 2019
@retrofox retrofox changed the title Link Control: make popover CSS rule stronger Link Control: fix setting rich-text placeholder Nov 13, 2019
Copy link
Member

obenland left a comment

Fixes that bug for me

@retrofox retrofox merged commit ddb9f99 into master Nov 13, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Nov 13, 2019
@retrofox retrofox deleted the update/link-popover-fix-visual-bug branch Nov 13, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.