Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Widget screen margins #18528

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Nov 14, 2019

Description

There was a change in the block editor margins and this change had the side effect of making the block editor not work as expected on the widget screen.
This PR fixes the problem.
cc: @mapk

How has this been tested?

I Verified the block editor on widgets screen looks as expected.

Screenshots

Before:
Screenshot 2019-11-14 at 18 37 19

After:
Screenshot 2019-11-14 at 18 34 48

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Nov 15, 2019

Unrelated with this PR but for me there's way too much margin at the top of the areas.

@jorgefilipecosta jorgefilipecosta force-pushed the fix/widget-screen-margins branch from 350346d to 25fa115 Nov 15, 2019
@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

jorgefilipecosta commented Nov 15, 2019

Unrelated with this PR but for me there's way too much margin at the top of the areas.

I added a fix for that problem in the PR 👍

@jorgefilipecosta jorgefilipecosta merged commit df00c7f into master Nov 15, 2019
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Failed
Details
@jorgefilipecosta jorgefilipecosta deleted the fix/widget-screen-margins branch Nov 15, 2019
@mapk

This comment has been minimized.

Copy link
Contributor

mapk commented Nov 21, 2019

It looks much better. Thanks for fixing this.

The only thing that looks off now is that the block appender width doesn't match the width of the actual blocks. Can that be adjusted?

Screen Shot 2019-11-20 at 8 20 25 PM

@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.