Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove one place for open in new window on menu item #18532

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Nov 14, 2019

Description

Fixes: #18320

How has this been tested?

I verified the UI to change Open in new tab now does not appear on the block inspector.
I verified the UI to change Open in new tab part of link popover is now on sentence case.
cc: @karmatosed

@jorgefilipecosta jorgefilipecosta force-pushed the chore/remove-one-place-for-open-in-new-window-on-menu-item branch from e071126 to 6ad10ea Nov 26, 2019
@jorgefilipecosta jorgefilipecosta merged commit 276dd9f into master Nov 26, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Nov 26, 2019
@jorgefilipecosta jorgefilipecosta deleted the chore/remove-one-place-for-open-in-new-window-on-menu-item branch Nov 26, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Navigation block
  
✅ Done
3 participants
You can’t perform that action at this time.