Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove unnecessary color attributes from navigation block #18540
To have a text color setting in the navigation block, we relied on four color attributes. In other blocks, we only use two attributes. I think we had some redundancy in the attributes.
It also solves some bugs:
How has this been tested?
I created multiple navigation blocks.
draganescu left a comment
Everything works as described.
Tested locally with by switching colors (primary, accent and custom) alternating usage of the control in the navigation block and the options in customizer.
Codewise we're having a cleaner approach with