Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Drop menu suffix #18551

Merged
merged 7 commits into from Nov 19, 2019
Merged

Navigation: Drop menu suffix #18551

merged 7 commits into from Nov 19, 2019

Conversation

@obenland
Copy link
Member

obenland commented Nov 15, 2019

Helps with minimizing the "menu" confusion for users and reestablishes hierarchy with core/navigation-link.

Fixes #18549 .

How has this been tested?

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@obenland obenland added this to 👀 PRs to review in Navigation block via automation Nov 18, 2019
@retrofox retrofox marked this pull request as ready for review Nov 18, 2019
@retrofox retrofox requested review from retrofox and removed request for Soean and ntwb Nov 18, 2019
@retrofox retrofox force-pushed the update/navigation branch from a95cb82 to 9b40c4e Nov 18, 2019
@obenland obenland mentioned this pull request Nov 18, 2019
2 of 6 tasks complete
Copy link
Contributor

getdave left a comment

I tested this manually and I couldn't find any references to "menu" remaining. Looking good.

Copy link
Contributor

retrofox left a comment

Tested and it looks good to me 🚢

@retrofox retrofox merged commit 24fbb35 into master Nov 19, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Nov 19, 2019
mkevins added a commit that referenced this pull request Nov 19, 2019
* Navigation: Drop menu suffix

* Update fixtures

* blocks: update navigation menu name

* navigation: fix php-lint/eslint errors
@noisysocks noisysocks mentioned this pull request Nov 21, 2019
12 of 12 tasks complete
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.