Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Navigation block: adds in default and style variation #18553
@draganescu can you code review as I think this can be easier worked out with #18466 - which doesn't work on this branch. Or if there's a way to get that picked up on branch I think we can get this working. In my testing I was forcing the class as no it doesn't seem to pick up. Any help there would be ace.
jasmussen left a comment
I left some comments, but this seems like the right approach:
There's still the accessibility challenge of tabbing through the menu items, but that's separate.
There's an issue with the variation preview itself:
I don't know what we can do here. I know we can provide some default example content here, Image block does that, but the change is only visible when the mouse hovers the menu item, which doesn't show up.
@gziolo can we show not the nav block but JUST the submenu here? I.e. custom markup for the preview?
FINALLY I think there's an open question whether this PR should make THREE styles.
This gives a little choice?
Something to think about.
I didn't follow the progress on Navigation block so I don't think I can help without taking a deep dive. I'm also attending WordCamp this week so I'd suggest asking someone else for help.
Took this for a spin again, and I think I have an idea for a good path forward.
However for some reason I can't get the styles to work anymore, not sure why. The code looks right, but for whatever,
However, once that is fixed up, I think you should do these things to get this shipping:
Does this make sense? What do you think?
This sounds great. Thanks so much.
@youknowriad are you able to or someone else help fix through the issue here?
… into try/nav-styles Brings a default to this but still has issues with mobile styling and also unsure what belongs in theme or what style to allow for variations. @jasmussen love your feedback on this approach. I can only think of this to have a default for Twenty Twenty being white with box-shadow. What seems to still be issue is the class being passed and it changing.