Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Navigation: Remove from experimental #18594
Removes the Navigation block from the experiments page and makes it accessible to anyone.
How has this been tested?
Loading menus in Editor and front-end on local test environment.
getdave left a comment
I tested this manually and I can confirm that the setting is removed from "Experiments" sub page in Gutenberg section.
I can also see the Block in the inserter by defalult without having to toggle anything "on".
From my limited knowledge of configuration for experiments (is this documented?) it looks like you've been pretty thorough.
I'd suggest it would be ideal to have someone from the Core team (@youknowriad?) look at this to ensure there aren't any other edge cases we're not aware of.
@youknowriad I've been thinking about this. Do you consider that a Blocker to launching this Block?
If (as I suspect) it's not, then could we (myself or @obenland) raise an Issue and address in a follow-up PR? I'm happy to take these on.
It's not but I suspect that the block right now is broken for contributor role and an e2e test will help catch that.
Sorry wrong slack link. Here's the correct one https://wordpress.slack.com/archives/C02QB2JS7/p1574173178189700