Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Remove from experimental #18594

Merged
merged 4 commits into from Nov 20, 2019

Conversation

@obenland
Copy link
Member

obenland commented Nov 18, 2019

Description

Removes the Navigation block from the experiments page and makes it accessible to anyone.

Depends on #18551.
Fixes #18550.

How has this been tested?

No more Navigation Block in the experimental Gutenberg section:

Loading menus in Editor and front-end on local test environment.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
Copy link
Contributor

getdave left a comment

Nice 👍

I tested this manually and I can confirm that the setting is removed from "Experiments" sub page in Gutenberg section.

I can also see the Block in the inserter by defalult without having to toggle anything "on".

From my limited knowledge of configuration for experiments (is this documented?) it looks like you've been pretty thorough.

I'd suggest it would be ideal to have someone from the Core team (@youknowriad?) look at this to ensure there aren't any other edge cases we're not aware of.

@retrofox retrofox changed the base branch from update/navigation to master Nov 19, 2019
@retrofox

This comment has been minimized.

Copy link
Contributor

retrofox commented Nov 19, 2019

Just FYI, I've changed the base to master, since #18551 is already :shipit:

@getdave getdave self-assigned this Nov 19, 2019
@getdave

This comment has been minimized.

Copy link
Contributor

getdave commented Nov 19, 2019

Taking this over for the meanwhile to finish it off.

@getdave getdave marked this pull request as ready for review Nov 19, 2019
Copy link
Contributor

youknowriad left a comment

How about adding some e2e tests to the navigation block? nothing exhaustive but something to ensure the basic interactions are working as intended?

@getdave

This comment has been minimized.

Copy link
Contributor

getdave commented Nov 19, 2019

How about adding some e2e tests to the navigation block? nothing exhaustive but something to ensure the basic interactions are working as intended?

@youknowriad I've been thinking about this. Do you consider that a Blocker to launching this Block?

If (as I suspect) it's not, then could we (myself or @obenland) raise an Issue and address in a follow-up PR? I'm happy to take these on.

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Nov 19, 2019

It's not but I suspect that the block right now is broken for contributor role and an e2e test will help catch that. https://wordpress.slack.com/archives/C02QB2JS7/p1574176694224900

@youknowriad

This comment has been minimized.

Copy link
Contributor

youknowriad commented Nov 19, 2019

Sorry wrong slack link. Here's the correct one https://wordpress.slack.com/archives/C02QB2JS7/p1574173178189700

@retrofox retrofox force-pushed the remove/nav-experimental branch from aa77e34 to 1922ea1 Nov 20, 2019
Copy link
Contributor

retrofox left a comment

Tested and LGTM.

@obenland obenland merged commit 3bbea89 into master Nov 20, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Nov 20, 2019
@obenland obenland deleted the remove/nav-experimental branch Nov 20, 2019
@getdave

This comment has been minimized.

Copy link
Contributor

getdave commented Nov 21, 2019

How about adding some e2e tests to the navigation block? nothing exhaustive but something to ensure the basic interactions are working as intended?

@youknowriad I looked and there's an Issue for automated testing. Not sure if/when I can get to that though for various reasons

@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.