Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the view section of the More Menu to the options panel #18601

Merged
merged 2 commits into from Nov 19, 2019

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Nov 19, 2019

I have found that the Editor modes (fullscreen, top toolbar and spotlight mode) are not options we trigger regularily, in general you choose an option and stick with it for a long time.

So in this PR, I'm moving them to the "options" panel. I feel it's a more logical location for them and it frees up the "More Menu" a little bit.

The concern here could be "discoverability" maybe? The counter-argument is that it's not mandatory for users to change options but if they want to, it's better if it's in a single place.

Thoughts?

Capture d’écran 2019-11-19 à 9 52 53 AM

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Nov 19, 2019

This seems good to me, including your reasoning. 👍 👍

This does highlight that we could give some visual love to the options dialog — there are quite a few horizontal lines that don't seem to add that much value. Not necessarily something to remove in this PR, but something to consider:

Screenshot 2019-11-19 at 10 34 46

To frame it differentlhy — the options dialog could use more or less the same visual layout for separation as exists in the dropdown.

Copy link
Contributor

jasmussen left a comment

Approving from a design POV, might still need a code sanity check.

@youknowriad

This comment has been minimized.

Copy link
Contributor Author

youknowriad commented Nov 19, 2019

This does highlight that we could give some visual love to the options dialog

My opinion is that it should be full screen modal with two columns :)

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Nov 19, 2019

My opinion is that it should be full screen modal with two columns :)

Hehe I know. I quite disagree with that — to me that changes it to a modal section as opposed to a modal dialog. There can be a place for both, but I believe there will always be a need for a dialog interface that shows the context of the parent interface. But this is a separate discussion ;)

@youknowriad

This comment has been minimized.

Copy link
Contributor Author

youknowriad commented Nov 19, 2019

I believe there will always be a need for a dialog interface that shows the context of the parent interface. But this is a separate discussion ;)

I changed my mind, I think there's a need for dialogs, but options I'm not certain it's a dialog. In general we have completely separate pages for settings and options.

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Nov 19, 2019

but options I'm not certain it's a dialog

Yep, I can agree with that.

@youknowriad youknowriad requested review from ajitbohra, nerrad and ntwb as code owners Nov 19, 2019
@youknowriad youknowriad merged commit fb234f5 into master Nov 19, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad deleted the try/move-views-to-options branch Nov 19, 2019
youknowriad added a commit that referenced this pull request Nov 22, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.