Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Title: fix special chars #18616

Merged
merged 1 commit into from Nov 19, 2019
Merged

Conversation

@retrofox
Copy link
Contributor

retrofox commented Nov 19, 2019

Description

This commit ensures setting rightly of the title content, escaping and unescaping from special chars.

How has this been tested?

Add special chars in the post title. Save. Check that the chars are not rightly escaped in the front-end.
It's possible to inject javascript from the title of the post:

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
This commit ensures setting rightly of the title content, escaping and unescaping from special chars.
@retrofox retrofox requested a review from talldan as a code owner Nov 19, 2019
@retrofox retrofox requested review from aduth and youknowriad and removed request for talldan Nov 19, 2019
@retrofox retrofox added the [Type] Bug label Nov 19, 2019
@retrofox retrofox merged commit c21dbfe into master Nov 19, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@retrofox retrofox deleted the update/fix-post-title-special-chars branch Nov 19, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.