Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clearing the block selection on sidebar tab switch #18621

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@draganescu
Copy link
Contributor

draganescu commented Nov 20, 2019

Description

Closes #18239

How has this been tested?

Tested locally.

Screenshots

no-selection-clearing

Types of changes

It is a simple update of the settings-header that removes the call to clearSelectedBlock.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
Copy link
Member

jorgefilipecosta left a comment

Hi, this works as expected from the code point of view. But I would wait on feedback from @jasmussen as the original author of #6887 before merging.

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Nov 22, 2019

Thanks. I've shared with Andrei that I think this is one of those things that, if it's a trivial amount of code, we can just go ahead and try it. I'm still not convinced it's actually preferable behavior, but if we merge and dislike, we can always revert. So no blockers from me!

Copy link
Member

jorgefilipecosta left a comment

LGTM 👍

@talldan talldan merged commit a06542d into master Dec 3, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@talldan talldan deleted the try/keep-block-selection-on-document-tab branch Dec 3, 2019
glendaviesnz pushed a commit to Automattic/wp-calypso that referenced this pull request Dec 4, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.