Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jest Puppeteer Axe: Add babel/runtime dependency #18626

Merged

Conversation

@microbit-mark
Copy link
Contributor

microbit-mark commented Nov 20, 2019

Description

This pull request seeks to add a missing dependency on @babel/runtime to the jest-puppeteer-axe package. See #14373 for additional context on why this is necessary:

Each package transpiled using Babel is configured to apply the Babel runtime transform (source). Thus, the built output for any package is expected to contain references to the @babel/runtime module. For this reason, the package must explicitly define @babel/runtime as a dependency.

@gziolo

This comment has been minimized.

Copy link
Member

gziolo commented Nov 20, 2019

Yes, it makes a lot of sense. Thanks for opening this PR. We have it covered in all other packages which require code transpilation. This repository has monorepo setup, could you update this patch to use the same version of the package as in other places and run npm install again:

"@babel/runtime": "^7.4.4",

This will ensure that everything works seamlessly. At the same time, it makes it clear that we should upgrade all Babel dependencies in separate Pull Request :)

Jest Puppeteer Axe: Update runtime for monorepo
@microbit-mark microbit-mark force-pushed the microbit-mark:add/jest-puppeteer-axe-runtime-dep branch from 864266c to c0be034 Nov 20, 2019
@microbit-mark

This comment has been minimized.

Copy link
Contributor Author

microbit-mark commented Nov 20, 2019

I have updated the dependency version and run npm install

@gziolo
gziolo approved these changes Nov 20, 2019
Copy link
Member

gziolo left a comment

Thank you, this looks great now. Thank you for the first code contribution to Gutenberg! 🎉

By the way, it will take at least another week until this change gets published to npm.

@gziolo gziolo merged commit d874824 into WordPress:master Nov 20, 2019
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Errored
Details
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.