Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: fix adding CSS custom class issue #18629

Merged
merged 1 commit into from Nov 20, 2019

Conversation

@retrofox
Copy link
Contributor

retrofox commented Nov 20, 2019

Description

It's a regression done by mistake. The original issue was taken over by @obenland (props!)

How has this been tested?

  • Create a navigation menu.

  • Set a custom color (from colors palette).
    image

  • Set a custom CSS class

Screen Shot 2019-11-20 at 9 17 11 AM

  • Save the post

Confirm that the HTML markup has both CSS classes:
Screen Shot 2019-11-20 at 9 17 57 AM

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
It's a regression done by mistake. The original issue was taken over by @obenland (props!)
@retrofox retrofox added this to 👀 PRs to review in Navigation block via automation Nov 20, 2019
@retrofox retrofox requested a review from obenland Nov 20, 2019
@retrofox retrofox changed the title navigation: fix adding CSS custom class issue. Navigation: fix adding CSS custom class issue Nov 20, 2019
Copy link
Member

obenland left a comment

Tested, :shipit:

@retrofox retrofox merged commit c79b5d9 into master Nov 20, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
Navigation block automation moved this from 👀 PRs to review to ✅ Done Nov 20, 2019
@retrofox retrofox deleted the update/navigation-add-custom-css-class branch Nov 20, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Navigation block
  
✅ Done
3 participants
You can’t perform that action at this time.