Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add BaseControl component #18648

Merged
merged 3 commits into from Nov 21, 2019

Conversation

@fernandovbs
Copy link
Contributor

fernandovbs commented Nov 20, 2019

Description

Adds baseControl component to storybook

How has this been tested?

Run npm run storybook:dev and confirm component shows
Adjust knobs

Types of changes

Storybook.

*/
import BaseControl from '../';

export default { title: 'Components|Base-control', component: BaseControl };

This comment has been minimized.

Copy link
@ItsJonQ

ItsJonQ Nov 21, 2019

Contributor

@fernandovbs Thank you for working on this one. I tested it locally, and it's working as expected. The only thing I'd adjust is the title Base-control -> Base Control

Thank you!~ 🙏

This comment has been minimized.

Copy link
@fernandovbs

fernandovbs Nov 21, 2019

Author Contributor

Hi @ItsJonQ, Got that.
Thank you for your reply. I'll change it now 😄

@@ -8,7 +8,7 @@ import { boolean, text } from '@storybook/addon-knobs';
*/
import BaseControl from '../';

export default { title: 'Components|Base-control', component: BaseControl };
export default { title: 'Components|Base Control', component: BaseControl };

This comment has been minimized.

Copy link
@ItsJonQ

ItsJonQ Nov 21, 2019

Contributor

@fernandovbs Awesome! One final tiny nitpick (apologies!). I think it should be BaseControl (no space). Just like the React component name :).

Thank you!

This comment has been minimized.

Copy link
@fernandovbs

fernandovbs Nov 21, 2019

Author Contributor

No problem 😄. Done!

Copy link
Contributor

ItsJonQ left a comment

🚀 from me! Thank you @fernandovbs !

@ItsJonQ ItsJonQ merged commit f1f7e81 into WordPress:master Nov 21, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.