Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden post schedule popover on mobile #18658

Merged
merged 1 commit into from Nov 21, 2019

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Nov 21, 2019

closes #18649

We had a special z-index hack introduced in #7621 (comment)

It looks like this regressed with #18044 but the good news is that removing the hack is the fix for the same issue it was introduced for :). It nice when hacky fixes remove them selves.

Testing instructions

  • Try opening the Post Schedule popover on mobile, it should show up properly.
// Used to prevent z-index issues on mobile.
// See: https://github.com/WordPress/gutenberg/pull/7621#issuecomment-424322735
.components-popover.edit-post-post-schedule__dialog.is-bottom.is-left {
z-index: 100000;

This comment has been minimized.

Copy link
@gwwar

gwwar Nov 21, 2019

Contributor

🔪

@gwwar
gwwar approved these changes Nov 21, 2019
Copy link
Contributor

gwwar left a comment

Thanks @youknowriad this tests well for me on both Desktop/Mobile size viewports!

@youknowriad youknowriad merged commit 983c60f into master Nov 21, 2019
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Canceled
Details
@youknowriad youknowriad deleted the fix/date-picker-popover-mobile branch Nov 21, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.