Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Move the block movers to the block toolbar #18685
There seems to be this weird bug that happens now. Try creating a columns block and dragging a block in one of the columns to the other column. Suddenly the selected block gets stuck in this weird state where its toolbar is gone and its content is invisible. This does not happen in
Aside from that issue, everything else seems to be working fine. I think the drag handle size could be reduced, especially if the move buttons also doubled as drag handles.
I think it would be helpful if the toolbar could extend to the left of the block border in tight situations like this one:
However, that's probably out of the scope of this PR.
I've confirmed that the dragging bug is fixed.
Something else I just noticed is that mobile now uses the same sibling inserter as the desktop. Also, the toolbar now overlaps the block below on mobile.
I think something needs to be done about the sibling inserter. I also prefer the no-overlap behavior of the
Thanks for the feedback @ZebulanStanphill
I actually didn't touch the sibling inserter at all, I believe you can still trigger it in master as well. I do think the in-between inserter is not that useful in mobile especially because the inserter is always accessible easily (top of the screen) and has the same behavior but I'm not going to touch these in this particular PR.
I'll have to check where the extra padding was added for the toolbar before and restore it.
I'm not 100% certain about moving the movers to the top bar (yet).
After playing around a bit...
I have an alternative interaction pattern idea that tried to lighten the UI re: movers.
(I don't know if this was tried previously).
The idea came from playing around with Notion (they don't use arrows in their mover though).
If this isn't the right thread to post this, please let me know!
These are my initial thoughts :)
As always, thank you!
Your proposal is a good alternative but it seems to move us into a different direction than the one suggested in #18667 so maybe we should figure out the path forward there?