Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-puppeteer-axe: add `options` and `config` parameters #18712

Merged
merged 3 commits into from Nov 29, 2019

Conversation

Copy link
Member

gziolo left a comment

Nice idea to expose those additional parameters.

It would be great to polish documentation as the number of options offered makes it harder to use for those not familiar with Axe.

This PR will also require new entry in the CHANGELOG file, it should be similar to:
https://github.com/WordPress/gutenberg/blob/master/packages/jest-puppeteer-axe/CHANGELOG.md#new-feature

packages/jest-puppeteer-axe/README.md Outdated Show resolved Hide resolved
packages/jest-puppeteer-axe/README.md Outdated Show resolved Hide resolved
packages/jest-puppeteer-axe/README.md Show resolved Hide resolved
packages/jest-puppeteer-axe/src/index.js Outdated Show resolved Hide resolved
Hypnosphi and others added 2 commits Nov 28, 2019
@gziolo
gziolo approved these changes Nov 29, 2019
Copy link
Member

gziolo left a comment

Thank you for wrangling all that, great work 💯

@gziolo gziolo merged commit a24cdd8 into WordPress:master Nov 29, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.