Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes broken links in JavaScript Tutorial TOC links #18713

Merged
merged 1 commit into from Nov 24, 2019
Merged

Conversation

@mkaz
Copy link
Member

mkaz commented Nov 24, 2019

Description

I attempted changing the links to relative in #18707, which appears to work elsewhere. This did not work when published to Gutenberg Handbook.

Broken links here: https://developer.wordpress.org/block-editor/tutorials/javascript/

@gziolo @chrisvanpatten
This confirm links must start from `/docs/

How has this been tested?

Confirmed links work via Github, can not be tested until published in Handbook.

Types of changes

Documentation.

@mkaz mkaz changed the title Fixes broken links in JavaScript Tutoial TOC links Fixes broken links in JavaScript Tutorial TOC links Nov 24, 2019
@mkaz mkaz merged commit 76d9598 into master Nov 24, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@mkaz mkaz deleted the add/fix-broken-js-links branch Nov 24, 2019
@youknowriad youknowriad added this to the Gutenberg 7.0 milestone Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.