Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Media & Text: "Crop image to fill entire column" reset on image change #18729

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Nov 25, 2019

Fix: #18684

Description

The image block was resetting the "Crop image to fill entire column" setting when an image was changed.

How has this been tested?

I added a media and text block.
I enabled "Crop image to fill entire column".
I changed the image.
I verified "Crop image to fill entire column" option was still enabled.

…s reset when changing image
@jorgefilipecosta jorgefilipecosta merged commit 58eb81c into master Nov 27, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@jorgefilipecosta jorgefilipecosta deleted the fix/media-text-Block-Crop-image-to-fill-entire-column-setting-is-reset-when-changing-image branch Nov 27, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
@dianeco

This comment has been minimized.

Copy link

dianeco commented Jan 20, 2020

@jorgefilipecosta The fix was working great but it was reverted by #18139

@jorgefilipecosta

This comment has been minimized.

Copy link
Member Author

jorgefilipecosta commented Jan 20, 2020

Hi @dianeco, thank you for noticing this issue 👍 I think the PR was reverted unintentionally during a merge I'm addressing the issue in #19765.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.