Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix: Disable HTML edit on cover #18730

merged 1 commit into from Nov 26, 2019


Copy link

jorgefilipecosta commented Nov 25, 2019


Fix: #18228

Blocks with InnerBlocks don't support HTML edit, and they crash when we open the block HTML edit functionality. In the other blocks with InnerBlocks we disabled the HTML editor to avoid these crashes, we missed the disable on the cover block.

How has this been tested?

I added a cover block.
I selected a background color.
I verified the "Edit as HTML" option was not available, on master it is and the block crashes when we go back to the visual edit.

@jorgefilipecosta jorgefilipecosta merged commit e4b5330 into master Nov 26, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
@jorgefilipecosta jorgefilipecosta deleted the fix/disable-html-on-cover-block branch Nov 26, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.