Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Testing: Download WordPress bleeding edge from GitHub #18773
This pull request seeks to update the Travis build preparation to install WordPress latest rather than the latest nightly build. The intention here is to resolve intermittent build failures caused by a corrupted ZIP file:
Upon further investigation, I was led to the conclusion that the downloads become interrupted when a new nightly version is uploaded, evidenced by the recentness of the
Since nightly builds are updated with regular frequency, this isn't too surprising. But the build tooling is not tolerant of these disrupted downloads, and will subsequently error.
Alternatives considered include:
Ultimately, while there might be some value in running the nightly version in the Travis build, it does not seem to be of critical importance; or at least, it is more important that the builds be stable. Furthermore, prior to #17004 we were running "latest" (not nightly), so this matches a known previous behavior.
For these reasons, the changes propose simply to replace the nightly download with a download of the latest stable version. I acknowledge that with these changes, we should consider to reopen the issue at #12839.
Travis build should pass.
There was some further discussion in Slack after submitting the pull request.
@dd32 points out that the nightly download shouldn't be disrupted as I suspected it was, even if a new version is uploaded while a download is in-progress.
@peterwilsoncc offered the suggestion to download the ZIP via GitHub (https://github.com/WordPress/WordPress/archive/master.zip). As best I can tell, this should serve just as well as the nightly (perhaps even more up-to-date than the nightly?). At the very least, it could be worth testing to see if it has any improvement.
Sadly, the errors still seem to occur, even downloading from GitHub:
Anecdotally, it doesn't seem to occur for me quite as frequently as before, but it remains a problem nonetheless.