Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move popovers and modals to the right position in the dom #18775

Merged
merged 1 commit into from Nov 29, 2019

Conversation

@youknowriad
Copy link
Contributor

youknowriad commented Nov 27, 2019

This PR restores the previous position for modals and popovers in the DOM. (before #18044)

It also ensures they are wrapped in FocusReturnProvider that way withFocusReturn should work properly there.

@youknowriad youknowriad requested a review from jorgefilipecosta Nov 27, 2019
@youknowriad youknowriad requested a review from talldan as a code owner Nov 27, 2019
@youknowriad youknowriad self-assigned this Nov 27, 2019
@gziolo
gziolo approved these changes Nov 29, 2019
Copy link
Member

gziolo left a comment

Makes sense to have it configured this way 👍

@youknowriad youknowriad merged commit be34e5b into master Nov 29, 2019
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Canceled
Details
@youknowriad youknowriad deleted the fix/move-popover-modal-dom branch Nov 29, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.