Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Avoid usage of editor store on block editor reusable blocks inserter #18784

Conversation

@jorgefilipecosta
Copy link
Member

jorgefilipecosta commented Nov 27, 2019

We want to remove the usages of editor inside block editor as that module may not be available. E.g: it is not available on widget screen.
This PR adds a new setting __experimentalFetchReusableBlocks that allows the block editor to trigger the fetching of the reusable blocks.

How has this been tested?

I verified the reusable blocks still work as expected.

@jorgefilipecosta jorgefilipecosta force-pushed the update/avoid-usage-of-core-editor-store-on-block-editor-reusable-blocks branch from 56275a7 to e6c17df Nov 27, 2019
Copy link
Contributor

youknowriad left a comment

LGTM 👍

I'm not sure yet what's the best approach here in order to remove the experimental flag. It's also not urgent to solve.

@jorgefilipecosta jorgefilipecosta merged commit c97ccf0 into master Nov 28, 2019
1 of 2 checks passed
1 of 2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Failed
Details
@jorgefilipecosta jorgefilipecosta deleted the update/avoid-usage-of-core-editor-store-on-block-editor-reusable-blocks branch Nov 28, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.