Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Skip the deploy stage on PRs. #18788

Merged
merged 1 commit into from Nov 27, 2019

Conversation

@epiqueras
Copy link
Contributor

epiqueras commented Nov 27, 2019

Follows #15159

Avoid dry-running the deploy stage in PRs to get the build time down.

See #17823 (comment).

@epiqueras epiqueras added this to the Future milestone Nov 27, 2019
@epiqueras epiqueras self-assigned this Nov 27, 2019
@epiqueras epiqueras requested a review from aduth Nov 27, 2019
@aduth
aduth approved these changes Nov 27, 2019
Copy link
Member

aduth left a comment

👍

@@ -197,7 +197,7 @@ jobs:
- $( npm bin )/wp-scripts test-e2e --config=./packages/e2e-tests/jest.config.js --cacheDirectory="$HOME/.jest-cache" --runTestsByPath $( awk 'NR % 4 == 3' < ~/.jest-e2e-tests )

- stage: deploy
if: branch = master
if: (NOT type IN (pull_request)) AND (branch = master)

This comment has been minimized.

Copy link
@aduth

aduth Nov 27, 2019

Member

Could be simpler as...

Suggested change
if: (NOT type IN (pull_request)) AND (branch = master)
if: type IN (push) AND branch = master

Reference: https://docs.travis-ci.com/user/conditions-v1#integration

I don't really know what api and cron are used for, but I doubt we want this stage to run for anything other than push.

This comment has been minimized.

Copy link
@epiqueras

epiqueras Nov 27, 2019

Author Contributor

api is for when you trigger a build through the API.

cron is for when a scheduled build runs.

We might have tools that trigger or schedule builds from master in the future and this would support that.

@epiqueras epiqueras merged commit 367c748 into master Nov 27, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@epiqueras epiqueras deleted the try/skipping-the-deploy-stage-on-prs branch Nov 27, 2019
@youknowriad youknowriad modified the milestones: Future, Gutenberg 7.1 Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.