Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText: add disabled prop #18792

Merged
merged 1 commit into from Nov 27, 2019
Merged

RichText: add disabled prop #18792

merged 1 commit into from Nov 27, 2019

Conversation

@ellatrix
Copy link
Member

ellatrix commented Nov 27, 2019

Description

This is the simplest way to disable. I guess some attributes don't make sense on a disabled element, but we can adjust if needed.

How has this been tested?

Set disabled to true on RichText.

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@SergioEstevao

This comment has been minimized.

Copy link
Contributor

SergioEstevao commented Nov 27, 2019

@ellatrix I assume we will need the same for the RN mobile component too? What is the context where this prop will be used?

@ellatrix

This comment has been minimized.

Copy link
Member Author

ellatrix commented Nov 27, 2019

It's for template locking I think. @epiqueras can probably provide more info. Not sure if we need it for mobile right now.

@epiqueras

This comment has been minimized.

Copy link
Contributor

epiqueras commented Nov 27, 2019

I assume we will need the same for the RN mobile component too? What is the context where this prop will be used?

Yes, eventually.

We need it for blocks/inputs that should be disabled when a user does not have permission to edit them. E.g. a Site Title block in a template being edited by a user that can't change the site's title.

@epiqueras epiqueras merged commit 9ecc89d into master Nov 27, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@epiqueras epiqueras deleted the add/rich-text-disabled branch Nov 27, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.