Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parent block title from block hover title. #18795

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@ZebulanStanphill
Copy link
Contributor

ZebulanStanphill commented Nov 27, 2019

Description

Since the editor now has a status bar containing block breadcrumbs, I think the block hover breadcrumb can be simplified to only show the title of the block being hovered. I think this makes the UI a bit clearer; I often found myself getting momentarily confused by the hover title, as the first word you see is not the title of the block you're hovering, but the immediate parent. Since the status bar provides a full breadcrumb of the selected block, I think the hover title should be simplified to only show the title of the hovered block.

How has this been tested?

I checked to make sure the breadcrumb was functional and looked right in both the navigation and standard (what is it called again?) modes.

I am unable to test the mobile version of the UI, but I have not modified the mobile version, and as far as I can tell, none of the changes in this PR should affect the mobile UI.

Screenshots

image
image

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .
@pablohoneyhoney

This comment has been minimized.

Copy link

pablohoneyhoney commented Nov 27, 2019

Very valid thinking here!
In the context of some initial exploratory, there are a couple of scenarios that can also help with this relevant exercise of reduction you are suggesting.

Like a simplified focus/selected state as pointed out in 18667

And even a way to navigate between parent and child as showed in 17267.

@ZebulanStanphill

This comment has been minimized.

Copy link
Contributor Author

ZebulanStanphill commented Nov 28, 2019

E2E test failure appears to be unrelated. I'm currently unable to run the E2E tests locally, so I've rebased the branch and repushed the changes to see if the test failure was intermittent. If not, I think I'll need some help figuring out what the issue is.

@ZebulanStanphill

This comment has been minimized.

Copy link
Contributor Author

ZebulanStanphill commented Nov 28, 2019

There was an E2E test failure again, but it wasn't the same test as last time, so I'm assuming the failures must be unrelated to the PR.

Copy link
Contributor

youknowriad left a comment

I agree with this change as well. @jasmussen thoughts?

@jasmussen

This comment has been minimized.

Copy link
Contributor

jasmussen commented Nov 28, 2019

Yep! Nice work!

@youknowriad youknowriad merged commit 353b384 into WordPress:master Nov 28, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@ZebulanStanphill ZebulanStanphill deleted the ZebulanStanphill:update/simplify-block-hover-title branch Nov 28, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.