Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor block toolbar to use hooks. #18843

Merged
merged 1 commit into from Nov 30, 2019
Merged

Conversation

@ZebulanStanphill
Copy link
Contributor

ZebulanStanphill commented Nov 30, 2019

Description

I refactored BlockToolbar (both standard and native versions) to use React hooks. There should be no behavioral changes in this PR.

How has this been tested?

I tested to make sure everything was working on desktop. I am unable to test the native version, but I can see no reason why it wouldn't work.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
@aduth
aduth approved these changes Nov 30, 2019
Copy link
Member

aduth left a comment

Looks good 👍

@aduth aduth merged commit dbd15a8 into master Nov 30, 2019
2 checks passed
2 checks passed
pull-request-automation
Details
Travis CI - Pull Request Build Passed
Details
@aduth aduth deleted the update/block-toolbar-use-hooks branch Nov 30, 2019
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.